Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pravega Operator API Resource Hook. #427

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Pravega Operator API Resource Hook. #427

merged 3 commits into from
Jul 24, 2020

Conversation

co-jo
Copy link
Member

@co-jo co-jo commented Jul 20, 2020

Change log description

  • Adds a manifest which defines a post-install/upgrade hook to make sure the pravegacluster resource exists.

Purpose of the change

  • If one is unlucky with the timings when install the pravega-operator chart, directly followed by the pravega chart, the api-resource PravegaCluster may not exist by the time the pravega chart tries to create a PravegaCluster.

What the code does

  • See above.

How to verify it

Run many install/uninstall cycles of the mentioned charts -- see that the pravega chart does not start before its resource dependency is registered.

@co-jo co-jo mentioned this pull request Jul 20, 2020
Closed
SrishT
SrishT approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@SrishT SrishT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the one minor change requested

@anishakj anishakj merged commit bea9dfe into pravega:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SrishT SrishT SrishT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@co-jo @SrishT @anishakj