Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart modifications #428

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Chart modifications #428

merged 2 commits into from
Jul 23, 2020

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Jul 23, 2020

Signed-off-by: SrishT [email protected]

Change log description

Makes changes to the charts to be able to add annotations to segmentstore and controller services. Also makes changes to the pravega installation script so it does not fail if uninstallation of a single component fails.

Signed-off-by: SrishT <[email protected]>
@SrishT SrishT requested a review from anishakj July 23, 2020 06:53
Signed-off-by: SrishT <[email protected]>
@SrishT SrishT requested a review from Prabhaker24 July 23, 2020 06:54
Copy link
Contributor

@Prabhaker24 Prabhaker24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020

Codecov Report

Merging #428 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   76.11%   76.11%           
=======================================
  Files          14       14           
  Lines        3320     3320           
=======================================
  Hits         2527     2527           
  Misses        705      705           
  Partials       88       88           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5afd9...9223dd2. Read the comment docs.

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit ee46298 into master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants