Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Documentation #438

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Updating Documentation #438

merged 1 commit into from
Aug 13, 2020

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Aug 12, 2020

Signed-off-by: SrishT [email protected]

Change log description

Updates documentation with the correct helm version required.

Signed-off-by: SrishT <[email protected]>
@SrishT SrishT requested a review from anishakj August 12, 2020 17:43
@codecov-commenter
Copy link

Codecov Report

Merging #438 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
+ Coverage   76.11%   76.13%   +0.02%     
==========================================
  Files          14       14              
  Lines        3320     3323       +3     
==========================================
+ Hits         2527     2530       +3     
  Misses        705      705              
  Partials       88       88              
Impacted Files Coverage Δ
pkg/apis/pravega/v1beta1/pravega.go 97.53% <ø> (ø)
pkg/controller/pravega/pravega_controller.go 100.00% <100.00%> (ø)
pkg/controller/pravega/pravega_segmentstore.go 100.00% <100.00%> (ø)
pkg/util/pravegacluster.go 97.45% <100.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f14a07...0b367e0. Read the comment docs.

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit ca32ef0 into master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants