Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 439: Post upgrade script for helm upgrades #440

Merged
merged 8 commits into from
Aug 25, 2020

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Aug 18, 2020

Signed-off-by: SrishT [email protected]

Change log description

After upgrading pravega operator from 0.4.5 to 0.5.x via helm, the helm release corresponding to the PravegaCluster resource is not updated and a separate helm release is not created corresponding to the newly created BookkeeperCluster resource. Due to this, no further helm operations can be done on the pravega and bookkeeper clusters post the operator upgrade.

Purpose of the change

Fixes #439

What the code does

Upgrades the helm release corresponding to the PravegaCluster resource and creates a separate helm release corresponding to the newly created BookkeeperCluster resource, after pravega operator is upgraded from 0.4.5 to 0.5.x via helm.

How to verify it

After the operator upgrade completes, run the post-upgrade script in the following way

$ ./post-upgrade.sh <name of pravega cluster> <pravega release name> <bookkeeper release name> <version of pravega cluster> <namespace> <zookeeper svc name>

After this script executes successfully, helm upgrade and helm uninstall on the pravega and bookkeeper releases will also succeed.

doc/operator-upgrade.md Show resolved Hide resolved
doc/operator-upgrade.md Outdated Show resolved Hide resolved
doc/operator-upgrade.md Outdated Show resolved Hide resolved
scripts/post-upgrade.sh Show resolved Hide resolved
scripts/post-upgrade.sh Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2020

Codecov Report

Merging #440 into master will decrease coverage by 0.09%.
The diff coverage is 47.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   76.11%   76.02%   -0.10%     
==========================================
  Files          14       14              
  Lines        3320     3328       +8     
==========================================
+ Hits         2527     2530       +3     
- Misses        705      710       +5     
  Partials       88       88              
Impacted Files Coverage Δ
pkg/apis/pravega/v1beta1/pravega.go 97.53% <ø> (ø)
pkg/apis/pravega/v1beta1/pravegacluster_types.go 14.92% <0.00%> (-0.12%) ⬇️
pkg/controller/pravega/pravega_controller.go 100.00% <100.00%> (ø)
pkg/controller/pravega/pravega_segmentstore.go 100.00% <100.00%> (ø)
pkg/util/pravegacluster.go 97.45% <100.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca32ef0...88d75fc. Read the comment docs.

Copy link
Contributor

@Prabhaker24 Prabhaker24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

@SrishT SrishT force-pushed the issue-439-helm-upgrades branch from 88d75fc to 0f2d68b Compare August 25, 2020 05:16
@anishakj anishakj merged commit 111190b into master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pravega and Bookkeeper releases not updated after upgrading pravega operator from 0.4 to 0.5 via helm
5 participants