Issue 445: Reuse values for helm releases in post-upgrade script

[SrishT]

Signed-off-by: SrishT [email protected]

Change log description

After upgrading the pravega operator from 0.4.5 to 0.5.1 via helm, the post-upgrade script which is used to upgrade the corresponding pravega release, does not reuse the values of its parameters from the existing setup. Instead, all these parameters are reset to their default values that have been specified in the new helm charts, which is undesirable.

Purpose of the change

Fixes #445

What the code does

• Accepts the bookkeeper replica count as an additional parameter in the post-upgrade script.
• Uses the reuse-values option while upgrading the pravega helm chart in order to preserve the properties that were set at the time of initial installation.

How to verify it

After the operator upgrade completes, run the post-upgrade script in the following way

$ ./post-upgrade.sh <name of pravega cluster> <pravega release name> <bookkeeper release name> <version of pravega cluster> <namespace> <zookeeper svc name> <bookkeeper replica count>

After this script executes successfully, the pravega release and the newly created bookkeeper release will be created, while retaining their previous configuration.

[codecov-commenter]

Codecov Report

Merging #446 into master will increase coverage by 0.36%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   76.11%   76.48%   +0.36%     
==========================================
  Files          14       15       +1     
  Lines        3320     3427     +107     
==========================================
+ Hits         2527     2621      +94     
- Misses        705      712       +7     
- Partials       88       94       +6     

Impacted Files	Coverage Δ
pkg/apis/pravega/v1beta1/pravega.go	97.53% <ø> (ø)
pkg/util/zookeeper_util.go	11.90% <11.90%> (ø)
pkg/apis/pravega/v1beta1/pravegacluster_types.go	24.92% <63.46%> (+9.88%)	⬆️
...roller/pravegacluster/pravegacluster_controller.go	62.88% <65.21%> (+0.67%)	⬆️
pkg/controller/pravega/pravega_controller.go	100.00% <100.00%> (ø)
pkg/controller/pravega/pravega_segmentstore.go	100.00% <100.00%> (ø)
pkg/util/pravegacluster.go	97.45% <100.00%> (-0.07%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7662f09...40720fc. Read the comment docs.

[anishakj]

LGTM

[Prabhaker24]

LGTM