-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating documentation and charts #453
Conversation
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
==========================================
- Coverage 76.11% 75.29% -0.83%
==========================================
Files 14 15 +1
Lines 3320 3068 -252
==========================================
- Hits 2527 2310 -217
+ Misses 705 669 -36
- Partials 88 89 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
README.md
Outdated
@@ -85,7 +85,7 @@ $ kubectl create -f ./example/pvc-tier2.yaml | |||
|
|||
#### Install a Pravega cluster | |||
|
|||
To understand how to deploy a pravega cluster using helm, refer to [this](charts/zookeeper#installing-the-chart). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this previously zookeeper and now changed to pravega?
|
||
Verify that the cluster instances and its components are being created. | ||
Once the pravega cluster with release name `bar` has been created, use the following command to verify that the cluster instances and its components are being created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the default name of pravegacluster release name to "pravega" as that's what is given as default pravega name in configmap for bookkeeper by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By giving a different release name, we are able to show that release name and cluster name might not always be the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that but in the bookkeeper configmap the name for pravega cluster is pravega so for a user deploying for the first time this will create an issue if he deploys pravega with any other release name other than pravega.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
Signed-off-by: SrishT <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: SrishT [email protected]
Change log description
Updates the operator documentation to reflect the changes in helm commands after the charts have been published to http://charts.pravega.io.