Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 452: Correcting setup script and updating documentation #455

Merged
merged 5 commits into from
Oct 1, 2020

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Sep 29, 2020

Signed-off-by: SrishT [email protected]

Change log description

To update the setup script to make use of the published charts which installs pravega along with its various dependencies. The failure policy of the webhooks also need to be modified so that the does not allow any pravega deployments if an incorrect certificate has been provided

Purpose of the change

Fixes #452

What the code does

Updates setup script touse published charts. Also modifies the failure policy of the Validating Webhook to make it fail in case an invalid certificate has been provided to it.

How to verify it

Pravega with all its dependencies should get deployed by providing the following command

./pravegacluster.sh deploy

Also, if the correct certificate has not been configured while installing the pravega operator, all pravega cluster deployments irrespective of their version should fail with the following error

Error: Internal error occurred: failed calling webhook "pravegawebhook.pravega.io": Post https://pravega-webhook-svc.default.svc:443/validate-pravega-pravega-io-v1beta1-pravegacluster?timeout=30s: x509: certificate signed by unknown authority

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2020

Codecov Report

Merging #455 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #455   +/-   ##
=======================================
  Coverage   75.29%   75.29%           
=======================================
  Files          15       15           
  Lines        3068     3068           
=======================================
  Hits         2310     2310           
  Misses        669      669           
  Partials       89       89           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4725943...28a6cf9. Read the comment docs.

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 287c621 into master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pravega setup script does not handle bookkeeper operator certificate creation
3 participants