Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 465: Fixing tls bad certificate issue #467

Merged
merged 4 commits into from
Oct 22, 2020
Merged

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Oct 20, 2020

Signed-off-by: SrishT [email protected]

Change log description

Pravega Operator logs contain http: TLS handshake error from 172.32.19.2:54178: remote error: tls: bad certificate logs even though a valid certificate has been configured.

Purpose of the change

Fixes #465 and #461

How to verify it

The pravega operator logs should not contain the following error logs after a pravega cluster installation when a valid certificate has been configured

2020/10/19 03:39:34 http: TLS handshake error from 172.32.10.2:33316: remote error: tls: bad certificate

Also when trying to install a pravega cluster version which is unsupported, the installation should fail with an error similar to the one shown below

Error from server (unsupported Pravega cluster version 0.9.2): error when creating "pravega.yaml": admission webhook "pravegawebhook.pravega.io" denied the request: unsupported Pravega cluster version 0.9.2

@SrishT SrishT force-pushed the issue-465-cert-issue branch from 5e3cd12 to c92d967 Compare October 22, 2020 09:52
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Prabhaker24 Prabhaker24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants