Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 473: Fixing charts to set the required LTS type #475

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Nov 5, 2020

Signed-off-by: SrishT [email protected]

Change log description

Currently even when the longTermStorageType is set to ecs or hdfs within the values.yaml, the ecs or hdfs configuration is not taking effect and the longTermStorageType of the deployed pravega cluster is getting set to filesystem in all cases.

Purpose of the change

Fixes #473 , #470

How to verify it

Following use-cases have been tested :

  • Deployed pravega cluster with storageType = ecs
  • Deployed pravega cluster with storageType = hdfs
  • Deployed pravega operator 0.4.5 with v1alpha1 pravega cluster. Upgraded the pravega operator to 0.5.2 followed by upgrading to v1beta1 pravega cluster.
  • Deployed pravega operator by setting webhookCert.generate within values.yaml to true and confirmed that the correct certificate name is used.

@SrishT SrishT marked this pull request as ready for review November 5, 2020 17:15
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set ECS or HDFS as tier2 using the latest charts
2 participants