Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-497: Added changes for configuring PDB #499

Merged
merged 5 commits into from
Jan 30, 2021

Conversation

Prabhaker24
Copy link
Contributor

Signed-off-by: prabhaker24 [email protected]

Change log description

This pr helps prevent segmentstore and controller pods from evicting if number of segmentstore or controller are greater than number of nodes. By making the PDB Configurable.

Purpose of the change

Fixes #497

What the code does

Added maxUnavailableControllerReplicas and maxUnavailableSgmentStoreReplicas fields which will be used to configure the controller and ss pdb respectively.

How to verify it

Modify the above two field and check inside the controller and ss PDB's they should have the modified values.

@codecov-io
Copy link

Codecov Report

Merging #499 (96043b0) into master (298ccf8) will increase coverage by 0.01%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   71.62%   71.63%   +0.01%     
==========================================
  Files          15       15              
  Lines        3411     3427      +16     
==========================================
+ Hits         2443     2455      +12     
- Misses        865      869       +4     
  Partials      103      103              
Impacted Files Coverage Δ
...roller/pravegacluster/pravegacluster_controller.go 51.37% <42.85%> (+0.17%) ⬆️
pkg/apis/pravega/v1beta1/pravega.go 97.56% <100.00%> (+0.19%) ⬆️
pkg/controller/pravega/pravega_controller.go 100.00% <100.00%> (ø)
pkg/controller/pravega/pravega_segmentstore.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 298ccf8...96043b0. Read the comment docs.

prabhaker24 added 2 commits January 27, 2021 00:31
Signed-off-by: prabhaker24 <[email protected]>
Signed-off-by: prabhaker24 <[email protected]>
@Prabhaker24 Prabhaker24 marked this pull request as ready for review January 26, 2021 19:16
prabhaker24 added 2 commits January 28, 2021 21:40
Copy link

@gaddamas gaddamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post the test results?

@Prabhaker24
Copy link
Contributor Author

Prabhaker24 commented Jan 29, 2021

Can you post the test results?

here's the link to the result for e2e test for the last commit https://github.com/pravega/pravega-operator/runs/1786620931

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 03fca50 into master Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Pod Disruption Budgets Configurable
4 participants