-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-497: Added changes for configuring PDB #499
Conversation
Signed-off-by: prabhaker24 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
+ Coverage 71.62% 71.63% +0.01%
==========================================
Files 15 15
Lines 3411 3427 +16
==========================================
+ Hits 2443 2455 +12
- Misses 865 869 +4
Partials 103 103
Continue to review full report at Codecov.
|
Signed-off-by: prabhaker24 <[email protected]>
Signed-off-by: prabhaker24 <[email protected]>
Signed-off-by: prabhaker24 <[email protected]>
Signed-off-by: prabhaker24 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you post the test results?
here's the link to the result for e2e test for the last commit https://github.com/pravega/pravega-operator/runs/1786620931 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: prabhaker24 [email protected]
Change log description
This pr helps prevent segmentstore and controller pods from evicting if number of segmentstore or controller are greater than number of nodes. By making the PDB Configurable.
Purpose of the change
Fixes #497
What the code does
Added maxUnavailableControllerReplicas and maxUnavailableSgmentStoreReplicas fields which will be used to configure the controller and ss pdb respectively.
How to verify it
Modify the above two field and check inside the controller and ss PDB's they should have the modified values.