Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 502: Pravega Operator pre-delete hook #503

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Feb 5, 2021

Change log description

Provides a pre-delete hook which ensures that custom resources are deleted before deleting the operator.

Purpose of the change

Fixes #502

What the code does

Allows the operator to be deleted via helm only if the PravegaCluster custom resource has already been deleted, not otherwise.

How to verify it

  • If you try to delete the pravega operator before having deleted the PravegaCluster custom resource, the pre-delete job will fail, thereby not allowing the operator from being deleted.
  • If you try to delete the pravega operator after the PravegaCluster custom resource has been cleaned up successfully, the operator will also be successfully deleted.

@SrishT SrishT force-pushed the issue-502-pre-delete-hook branch from c673414 to a8d0546 Compare February 5, 2021 04:24
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 426029c into master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No pre-delete hook in pravega operator chart
2 participants