Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-505: Added changes for Avoiding 2 Restarts when Both Version and cm changes are done at the same time #506

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

Prabhaker24
Copy link
Contributor

Signed-off-by: prabhaker24 [email protected]

Change log description

Added changes for Avoiding 2 Restarts when Both Version and cm changes are done at the same time. This makes the upgrade process fast and we don't get error messages due to race condition.

Purpose of the change

Fixes #505

What the code does

Code checks for any change in the version of the bk cluster when there are changes in cm and if there is change in the version
then we skip restart of pods and only upgrade the cm

How to verify it

Install pravega cluster then upgrade the cluster along with changing some field in the option we should only see one restart of all pravega(controller and ss) pods and the upgrade should complete.

@codecov-io
Copy link

Codecov Report

Merging #506 (d37d817) into master (03fca50) will decrease coverage by 0.00%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage   71.75%   71.75%   -0.01%     
==========================================
  Files          15       15              
  Lines        3449     3456       +7     
==========================================
+ Hits         2475     2480       +5     
- Misses        868      870       +2     
  Partials      106      106              
Impacted Files Coverage Δ
...roller/pravegacluster/pravegacluster_controller.go 51.63% <38.46%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03fca50...d37d817. Read the comment docs.

@Prabhaker24 Prabhaker24 requested a review from anishakj February 10, 2021 06:12
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 2daf478 into master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message is seen while upgrading Pravega Cluster along with CM Changes in Pravega cluster
3 participants