Issue 515: add customized labels support #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anishakj
requested changes
Mar 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
==========================================
- Coverage 71.78% 71.74% -0.04%
==========================================
Files 15 15
Lines 3459 3469 +10
==========================================
+ Hits 2483 2489 +6
- Misses 870 872 +2
- Partials 106 108 +2
Continue to review full report at Codecov.
|
Signed-off-by: Aaron Wu <[email protected]>
Signed-off-by: Aaron Wu <[email protected]>
Signed-off-by: Aaron Wu <[email protected]>
Signed-off-by: Aaron Wu <[email protected]>
Signed-off-by: Aaron Wu <[email protected]>
realAaronWu
force-pushed
the
feature-add-logging-support
branch
from
e7a5d53 to
f79bb56
Compare
realAaronWu
changed the title
realAaronWu
changed the title
CraneShiEMC
pushed a commit
to CraneShiEMC/pravega-operator
that referenced
this pull request
Mar 16, 2021
* add annotation support Signed-off-by: Aaron Wu <[email protected]> * add fields to crds Signed-off-by: Aaron Wu <[email protected]> * check nil Signed-off-by: Aaron Wu <[email protected]> * add values, update doc, fix UT Signed-off-by: Aaron Wu <[email protected]> * add deepcopy generated code Signed-off-by: Aaron Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
add controllerPodLabels and segmentStorePodLabels field in the crd, each one is a map with key as the label key and value as the label value.
Purpose of the change
Fixes #515
What the code does
add labels to the controller deployment and pods, and segmentstore sts and pods
How to verify it
deploy pravega with labels set see if labels are attached to pods