Issue 534: Provide support to configure segment store port #535
Conversation
Signed-off-by: anishakj <[email protected]>
There was a problem hiding this comment.
Overall this looks good, however when customizing port in single IP environment (multiple segmentstores exposed on single IP with different ports) customer should be aware they still need to open-up ports on firewall, since we take configured port and increment for each additional ss replica.
Signed-off-by: anishakj <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 70.55% 70.43% -0.13%
==========================================
Files 15 15
Lines 3573 3616 +43
==========================================
+ Hits 2521 2547 +26
- Misses 932 942 +10
- Partials 120 127 +7
Continue to review full report at Codecov.
|
RaulGracia
changed the title
Signed-off-by: anishakj <[email protected]>
| if err != nil { | ||
| return fmt.Errorf("failed to obtain configmap: %v", err) | ||
| } | ||
| javaopts := cm.Data["JAVA_OPTS"] |
There was a problem hiding this comment.
there can also be a check to see if the configmap is nil and to check whether it contains the provided key or not. Also the key being passed can be another argument passed to the method to make it more flexible.
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj [email protected]
Change log description
Provided support to configure segment store ports. If the port is not mentioned in pravega options,default port will be set as
12345Purpose of the change
Fixes #534
What the code does
Added support to configure segment store port.
How to verify it
Verified that segment store pods are coming up with different port number, if it is configured.
If port number is not specified, segment store pod is coming up with default port number
Verified changing segment store port at run time after Pravega is installed.
Verified changing segment store port at run time after Pravega is installed with external access.