Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 538: Support of customized pod annotation for Pravega pods #543

Merged
merged 7 commits into from
May 10, 2021

Conversation

anishakj
Copy link
Contributor

@anishakj anishakj commented May 7, 2021

Signed-off-by: anishakj [email protected]

Change log description

Added new spec parameter for annotations so that annotations can be customized

Purpose of the change

Fixes #538

What the code does

Provide support to configure annoatations

How to verify it

Verify that annotation configured are shown in pod describe output

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2021

Codecov Report

Merging #543 (e4d5655) into master (7ac2337) will increase coverage by 0.16%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
+ Coverage   71.78%   71.95%   +0.16%     
==========================================
  Files          15       15              
  Lines        3640     3662      +22     
==========================================
+ Hits         2613     2635      +22     
  Misses        911      911              
  Partials      116      116              
Impacted Files Coverage Δ
pkg/apis/pravega/v1beta1/zz_generated.deepcopy.go 95.83% <75.00%> (-0.66%) ⬇️
pkg/apis/pravega/v1beta1/pravega.go 98.11% <100.00%> (+0.11%) ⬆️
pkg/apis/pravega/v1beta1/pravegacluster_types.go 26.14% <100.00%> (+1.04%) ⬆️
pkg/controller/pravega/pravega_controller.go 90.00% <100.00%> (ø)
pkg/controller/pravega/pravega_segmentstore.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac2337...e4d5655. Read the comment docs.

anishakj added 3 commits May 8, 2021 01:17
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
@anishakj anishakj marked this pull request as ready for review May 8, 2021 11:57
charts/pravega/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@SrishT SrishT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 388128c into master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support of customized pod annotation for pravega pods
3 participants