Issue 280: Read InfluxDB credentials from a secret #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anishakj <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #563 +/- ##
==========================================
+ Coverage 73.29% 74.56% +1.26%
==========================================
Files 15 15
Lines 4093 4144 +51
==========================================
+ Hits 3000 3090 +90
+ Misses 967 932 -35
+ Partials 126 122 -4
Continue to review full report at Codecov.
|
Signed-off-by: anishakj <[email protected]>
SrishT
requested changes
Jul 21, 2021
pkg/apis/pravega/v1beta1/pravega.go
Outdated
| @@ -228,6 +228,9 @@ type PravegaSpec struct { | |||
|
|
|||
| // Details of authplugin to be copied into pravega controller | |||
| AuthImplementations *AuthImplementationSpec `json:"authImplementations,omitempty"` | |||
|
|
|||
| // Name of Secret containing Password based Authentication Parameters like username, password | |||
There was a problem hiding this comment.
description should specify that this secret is specific to the influxdb credentials
| @@ -276,6 +277,20 @@ func configureControllerAuthSecrets(podSpec *corev1.PodSpec, p *api.PravegaClust | |||
| } | |||
| } | |||
|
|
|||
| func configureControllerInfluxDBSecrets(podSpec *corev1.PodSpec, p *api.PravegaCluster) { | |||
| if p.Spec.Pravega.InfluxDBSecret != "" { | |||
| addSecretVolumeWithMount(podSpec, p, influxDBSecretVolumeName, p.Spec.Pravega.InfluxDBSecret, | |||
There was a problem hiding this comment.
could we consider accepting the mount path as a property from the user instead of hardcoding its value in a constant?
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
Signed-off-by: anishakj <[email protected]>
…into issue-influxdb-secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anishakj [email protected]
Change log description
Added a new field
InfluxDBSecretin Pravega spec, so that users can mention the secret names rather than passing username/password as plain text.Purpose of the change
Fixes #280
What the code does
It will read the secret from the user, and if it is mentioned secret is mounted in controller and segment store pods at
/etc/influxdb-secret-volume/How to verify it
Verified that secret is mounted at controller and segment store pods.