Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 564: Removing supported versions configmap #565

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Jul 14, 2021

Signed-off-by: SrishT [email protected]

Change log description

Removes the supported versions configmap from the pravege operator.

Purpose of the change

Fixes #564

What the code does

Removes the version validation from the validating webhook at the time of installation or upgrades of the pravega cluster. However the webhook will continue to check the format of the image being provided and will not allow any downgrade, unless while trying to rollback the cluster in case of a failed upgrade.

How to verify it

The pravega operator should allow installation of any pravega version given in the correct format (i.e. MAJOR.MINOR.PATCH-XXXX), and should also allow upgrades to any other pravega version. Downgrades are however not allowed.

The following scenarios have been tested

  • Upgrading the pravega operator from version 0.5.4 (which contains the version map) to the latest one (not containing the version map)
  • Tested installation and upgrade to any pravega version is allowed
  • Tested that the pravega operator does not allow using images which do not follow semantic versioning, and also does not allow the user from downgrading the pravega version

@medvedevigorek medvedevigorek requested a review from anishakj July 14, 2021 23:52
@SrishT SrishT marked this pull request as ready for review July 16, 2021 10:07
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all the references of version map from documentation.

pkg/apis/pravega/v1beta1/pravegacluster_types.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #565 (f2accc4) into master (087b0fb) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
+ Coverage   73.25%   73.29%   +0.03%     
==========================================
  Files          15       15              
  Lines        4121     4093      -28     
==========================================
- Hits         3019     3000      -19     
+ Misses        972      967       -5     
+ Partials      130      126       -4     
Impacted Files Coverage Δ
pkg/apis/pravega/v1beta1/pravegacluster_types.go 26.73% <66.66%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087b0fb...f2accc4. Read the comment docs.

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supported versions configmap should be removed
3 participants