Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 566: Including operator base version in Makefile #567

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Jul 19, 2021

Signed-off-by: SrishT [email protected]

Change log description

Hardcodes the base version of the operator in the Makefile, which needs to be updated after every pravega operator release, to serve as the base version.

Purpose of the change

Fixes #566

What the code does

Hardcodes the pravega operator base version in the Makefile to compute the version for pravega operator images that are build using make build-image command.
The final version for the pravega operator is computed in the following format inside the Makefile

{base_version}-{number_of_commits}-{commit_id}

How to verify it

Running the command make build-image should build the pravega operator image with version in the desired format

@SrishT SrishT requested a review from anishakj July 19, 2021 08:38
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2021

Codecov Report

Merging #567 (0f883c5) into master (01b7755) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #567   +/-   ##
=======================================
  Coverage   73.29%   73.29%           
=======================================
  Files          15       15           
  Lines        4093     4093           
=======================================
  Hits         3000     3000           
  Misses        967      967           
  Partials      126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b7755...0f883c5. Read the comment docs.

Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 8d45948 into master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include provision to specify and increment operator version on the master after every release
3 participants