Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 620: Fix for pravega upgrade failure #627

Merged
merged 1 commit into from
May 19, 2022

Conversation

anishakj
Copy link
Contributor

Signed-off-by: anishakj [email protected]

Change log description

While doing upgrade of pravega cluster, we are finding outdated pod in segment store using the pravega cluster labels. Since the controller and segment store share the same labels, outdated pod lists controller pod as well and upgrade is not happening correctly.

Purpose of the change

Fixes #620

What the code does

Corrected the labels for finding outdated pod

How to verify it

Verified that upgrade is working fine

@anishakj anishakj requested a review from nishant-yt May 19, 2022 05:04
@codecov-commenter
Copy link

Codecov Report

Merging #627 (f0da663) into master (43108bf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   82.81%   82.82%           
=======================================
  Files          17       17           
  Lines        4068     4069    +1     
=======================================
+ Hits         3369     3370    +1     
  Misses        565      565           
  Partials      134      134           
Impacted Files Coverage Δ
controllers/upgrade.go 72.97% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43108bf...f0da663. Read the comment docs.

Copy link
Collaborator

@nishant-yt nishant-yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 6fc2aae into master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade of pravega image is failing in certain cases
3 participants