Issue 630: Updating controller pdb policy #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anishakj <[email protected]>
anishakj
requested review from
jkhalack,
nishant-yt and
twincitiesguy
and removed request for
twincitiesguy
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
==========================================
- Coverage 82.82% 82.78% -0.04%
==========================================
Files 17 17
Lines 4069 4073 +4
==========================================
+ Hits 3370 3372 +2
- Misses 565 566 +1
- Partials 134 135 +1
Continue to review full report at Codecov.
|
jkhalack
reviewed
May 26, 2022
controllers/pravega_controller.go
Outdated
| minAvailable := intstr.FromInt(int(p.Spec.Pravega.MaxUnavailableControllerReplicas)) | ||
| var maxUnavailable intstr.IntOrString | ||
|
|
||
| if p.Spec.Pravega.MaxUnavailableControllerReplicas == int32(1) { |
There was a problem hiding this comment.
Did you intend to use another parameter here?
The description says the decision is to be based on replica count:
Also if the replica count is 1 setting maxunavailable replicas to 0 as in segment store
There was a problem hiding this comment.
Thanks @jkhalack . I have corrected it.
Signed-off-by: anishakj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anishakj [email protected]
Change log description
Updating the controller PDB policy
Purpose of the change
Fixes #630
What the code does
Currently in controller PDB, the
maxunavailableReplicasset in values file is used forminAvailable. Corrected the policy. Also if the replica count is 1 setting maxunavailable replicas to0as in segment storeHow to verify it
Verified that able to configure PDB with these settings