Issue 646: Add support for providing customized environment variables to controller #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to controller Signed-off-by: anisha.kj <[email protected]>
jkhalack
reviewed
Dec 2, 2022
| @@ -211,6 +211,9 @@ func makeControllerPodSpec(p *api.PravegaCluster) *corev1.PodSpec { | |||
| if p.Spec.Pravega.ControllerInitContainers != nil { | |||
| podSpec.InitContainers = append(podSpec.InitContainers, p.Spec.Pravega.ControllerInitContainers...) | |||
| } | |||
| if p.Spec.Pravega.ControllerEnvVars != nil { | |||
| podSpec.Containers[0].Env = p.Spec.Pravega.ControllerEnvVars | |||
| } | |||
There was a problem hiding this comment.
Should not we rather append it to the existing array, like it's done for segment store?
There was a problem hiding this comment.
For controller pods, there is no Env added to podspec as in segmentstore. That is the reason added like this
There was a problem hiding this comment.
I think it clashes with this assignement:
pravega-operator/controllers/pravega_controller.go
Lines 288 to 294 in 5ddeabd
There was a problem hiding this comment.
Thanks @jkhalack for pointing this. I have modified it as suggested
Signed-off-by: anisha.kj <[email protected]>
anishakj
force-pushed
the
issue-146-customize-controller-env
branch
from
5ddeabd to
92236f8
Compare
derekm
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anisha.kj [email protected]
Change log description
Added support to provide customized env variables to controller pods
Purpose of the change
Fixes #646
What the code does
Added new field
ControllerEnvVarsin Pravega spec. Also updated CRDHow to verify it
Verified that able to provide customized env variables to controller pods