Issue 657: Providing support to update controller service annotations #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anisha.kj <[email protected]>
jkhalack
reviewed
Mar 6, 2023
| } else { | ||
| return err | ||
| } | ||
|
|
There was a problem hiding this comment.
(nitpicking) Could you remove the extra empty lines from the new code to conform to the file formatting? Thanks!
Signed-off-by: anisha.kj <[email protected]>
jkhalack
reviewed
Mar 6, 2023
| err = r.Client.Create(context.TODO(), service) | ||
| if err != nil && !errors.IsAlreadyExists(err) { | ||
| return err | ||
| } | ||
|
|
There was a problem hiding this comment.
here are you suggesting to remove the IsAlreadyExists check?
Signed-off-by: anisha.kj <[email protected]>
jkhalack
approved these changes
Mar 6, 2023
krishan-Rai
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Added support to update the annotations and labels at run time for controller service
Purpose of the change
Fixes #657
What the code does
In controller reconcile service, if there is change in service like annotations, labels it will be updated
How to verify it
Verified by adding new annotations at run time