Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 668: Fix for system tests failure #669

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

anishakj
Copy link
Contributor

Change log description

Added null check for function validateAuthenticationSettings

Purpose of the change

Fixes #668

What the code does

If Authentication is set as null in pravega yaml, operator was not able to deploy pravega

How to verify it

Deployed Pravega via system tests.

Copy link

@krishan-Rai krishan-Rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 2881c61 into master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System tests are failing with latest version of pravega operator
3 participants