Issue 670: Updating the segmentstore port #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anisha.kj <[email protected]>
jkhalack
reviewed
Sep 11, 2023
| @@ -641,6 +641,7 @@ func MakeSegmentStoreExternalServices(p *api.PravegaCluster) []*corev1.Service { | |||
| } | |||
| if p.Spec.Pravega.SegmentStoreLoadBalancerIP != "" { | |||
| service.Spec.Ports[0].Port = int32(serviceport) + i | |||
| service.Spec.Ports[1].Port = int32(adminPort) + i | |||
There was a problem hiding this comment.
@anishakj is it expected to go up (9999, 1000, 1001) or down (9999, 9998, 9997)?
There was a problem hiding this comment.
ports are supported upto 65535 i made it similar for 12345 port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Updating the segment store service port incrementally if
SegmentStoreLoadBalancerIPis setPurpose of the change
Fixes #670
What the code does
If we are using same segment store service IP with different ports, in case of admin port as well port number needs to be incremented. If it is not incremented will give port conflict
How to verify it
Verify segment store pods are coming up fine