Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 643: Fixing intermittent upgrade failure #672

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

anishakj
Copy link
Contributor

@anishakj anishakj commented Oct 9, 2023

Change log description

Fixing intermittent upgrade failure of pravega.
Added some more conditions to handle error scenarios

Purpose of the change

Fixes #643

What the code does

while during segmentstore update, it fails to get the pod sometimes. Issue is happening because while it tries to get an outdated pod, it has already updated. So added more checks to post error only if all pods were not updated

How to verify it

Peformed upgrade multiple time and issue is not seen

@anishakj anishakj requested a review from jkhalack October 9, 2023 14:40
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2d60c29) 82.37% compared to head (3986b90) 82.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   82.37%   82.27%   -0.10%     
==========================================
  Files          17       17              
  Lines        4130     4136       +6     
==========================================
+ Hits         3402     3403       +1     
- Misses        583      586       +3     
- Partials      145      147       +2     
Files Coverage Δ
controllers/upgrade.go 72.04% <16.66%> (-0.77%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: anisha.kj <[email protected]>
controllers/upgrade.go Outdated Show resolved Hide resolved
Signed-off-by: anisha.kj <[email protected]>
@anishakj anishakj marked this pull request as ready for review October 10, 2023 13:27
@anishakj anishakj requested a review from krishan-Rai October 10, 2023 16:23
Copy link

@krishan-Rai krishan-Rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit d970e05 into master Oct 11, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pravega cluster upgrade is failing intermittently
4 participants