Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 79: Ability to configure non-default service accounts #80

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Issue 79: Ability to configure non-default service accounts #80

merged 1 commit into from
Nov 8, 2018

Conversation

adrianmo
Copy link
Contributor

@adrianmo adrianmo commented Nov 8, 2018

Change log description

  • Update PravegaCluster API spec to allow users to optionally set service account names for BookKeeper, Pravega Controller, and Pravega Segmentstore.
  • Update Pod spec in StatefulSet and Deployment pod templates to include the service account names if they are set.
  • Update README file with instructions on how to configure the non-default service accounts.
  • Refactor README structure. Create a new "Configuration" section that includes existing configuration information.

Purpose of the change

Signed-off-by: Adrian Moreno [email protected]

@adrianmo adrianmo self-assigned this Nov 8, 2018
@adrianmo adrianmo requested a review from EronWright November 8, 2018 16:12
EronWright
EronWright approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@EronWright EronWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@adrianmo adrianmo requested a review from sarlaccpit November 8, 2018 16:44
@EronWright EronWright merged commit ddc852b into master Nov 8, 2018
@EronWright EronWright deleted the issue-79-configure-service-accounts branch November 8, 2018 20:46
@adrianmo adrianmo changed the title [WiP] Issue 79: Ability to configure non-default service accounts Issue 79: Ability to configure non-default service accounts Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarlaccpit sarlaccpit sarlaccpit approved these changes

@EronWright EronWright EronWright approved these changes

Assignees

@adrianmo adrianmo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrianmo @EronWright @sarlaccpit