-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 82: Ability to scale Pravega Controller #99
Conversation
Signed-off-by: Adrian Moreno <[email protected]>
@shrids please take a look at this change and let me know if it unblocks your work on pravega/pravega#3135 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested and verified that Pravega Controller scaling works fine with this fix.
Change log description
This PR adds the ability to scale the number of Controller replicas. It has been implemented in the
pkg/pravega/sync.go
file, in the same way as other components are scaled (Segmentstore, Bookkeeper), i.e., the code obtains the desired number of replicas from the updated manifest and makes sure the ControllerDeployment
object is in sync.Purpose of the change
How to test the change
Checkout the repository (
master
branch is fine, no need to checkout this branch).Edit the operator image used in the
deploy/operator.yaml
file to use theadrianmo/pravega-operator:issue-82-1
image, which contains the changes in this PR.Follow the instructions in the README file to install the operator, deploy the operator, and create a Pravega cluster.
By default, there will only be one Controller replica.
To scale the number of Controller replicas, edit the
PravegaCluster
resource and update thecontrollerReplicas
field.Verify that the number of Controller pods matches with the number of replicas.
Run a Pravega sample as explained here to verify that Pravega works as expected.
Signed-off-by: Adrian Moreno [email protected]