Prevent dual package hazard in webpack5 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With webpack 5 package exports are now supported. This can lead to the esm dual package hazard when both the commonjs and the esm version is loaded. This happens in nextjs during prerendering and breaks singeltons like hooks.
|
@marvinhagemeister Hi! Do you know when it will be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable package exports field resolution in webpack. It can lead to dual package hazards where packages are imported twice: One
commonjsversion and oneESMversion. This breaks hooks which have to rely on a singleton by design (nothing we can do about that).There is an official section about that in the node documentation.
Resolves the part of #25 where hooks were failing.