Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CLI output for compilation warnings #851

Merged
merged 1 commit into from
Sep 5, 2021
Merged

Conversation

marvinhagemeister
Copy link
Member

Instead of just showing the warning message we'll now show where the warning came from and potentially display a code frame of the code if available.

Before:

Screenshot 2021-09-05 at 18 36 47

After:

Screenshot 2021-09-05 at 18 31 59

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2021

🦋 Changeset detected

Latest commit: 504af20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wmr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2021

Size Change: +260 B (0%)

Total Size: 804 kB

Filename Size Change
packages/wmr/wmr.cjs 767 kB +260 B (0%)
ℹ️ View Unchanged
Filename Size
examples/demo/dist/about/index.html 713 B
examples/demo/dist/alias-outside/index.html 693 B
examples/demo/dist/assets/Calendar.********.css 702 B
examples/demo/dist/assets/style.********.css 624 B
examples/demo/dist/chunks/alias-outside.********.js 138 B
examples/demo/dist/chunks/class-fields.********.js 211 B
examples/demo/dist/chunks/compat.********.js 15.3 kB
examples/demo/dist/chunks/hoofd.module.********.js 1.48 kB
examples/demo/dist/chunks/index.********.js 267 B
examples/demo/dist/chunks/json.********.js 239 B
examples/demo/dist/chunks/meta-tags.********.js 300 B
examples/demo/dist/chunks/prerender.********.js 294 B
examples/demo/dist/class-fields/index.html 704 B
examples/demo/dist/compat/index.html 1.55 kB
examples/demo/dist/env/index.html 779 B
examples/demo/dist/error/index.html 708 B
examples/demo/dist/files/index.html 739 B
examples/demo/dist/index.********.js 7.74 kB
examples/demo/dist/index.html 770 B
examples/demo/dist/json/index.html 712 B
examples/demo/dist/lazy-and-late/index.html 714 B
examples/demo/dist/meta-tags/index.html 782 B

compressed-size-action

@developit developit self-requested a review September 5, 2021 17:02
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

@marvinhagemeister marvinhagemeister merged commit cdcbded into main Sep 5, 2021
@marvinhagemeister marvinhagemeister deleted the rollup-warn branch September 5, 2021 17:04
This was referenced Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants