Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when using static class fields #858

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Sep 8, 2021

This code did throw an error due to the static class field:

class Foo {
  static state = 'class fields work';
}

This was already reported a while back in #708, but I didn't know that acorn needs a special plugin for static fields.

Fixes #708 .

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2021

🦋 Changeset detected

Latest commit: 9fbafb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wmr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

Size Change: +499 B (0%)

Total Size: 804 kB

Filename Size Change
packages/wmr/wmr.cjs 768 kB +499 B (0%)
ℹ️ View Unchanged
Filename Size
examples/demo/dist/about/index.html 713 B
examples/demo/dist/alias-outside/index.html 693 B
examples/demo/dist/assets/Calendar.********.css 702 B
examples/demo/dist/assets/style.********.css 624 B
examples/demo/dist/chunks/alias-outside.********.js 138 B
examples/demo/dist/chunks/class-fields.********.js 211 B
examples/demo/dist/chunks/compat.********.js 15.3 kB
examples/demo/dist/chunks/hoofd.module.********.js 1.48 kB
examples/demo/dist/chunks/index.********.js 267 B
examples/demo/dist/chunks/json.********.js 239 B
examples/demo/dist/chunks/meta-tags.********.js 300 B
examples/demo/dist/chunks/prerender.********.js 294 B
examples/demo/dist/class-fields/index.html 704 B
examples/demo/dist/compat/index.html 1.55 kB
examples/demo/dist/env/index.html 779 B
examples/demo/dist/error/index.html 708 B
examples/demo/dist/files/index.html 739 B
examples/demo/dist/index.********.js 7.74 kB
examples/demo/dist/index.html 770 B
examples/demo/dist/json/index.html 712 B
examples/demo/dist/lazy-and-late/index.html 714 B
examples/demo/dist/meta-tags/index.html 782 B

compressed-size-action

@marvinhagemeister marvinhagemeister merged commit ce207d3 into main Sep 8, 2021
@marvinhagemeister marvinhagemeister deleted the static-class-fields branch September 8, 2021 06:24
@github-actions github-actions bot mentioned this pull request Sep 8, 2021
@lgarron
Copy link

lgarron commented Sep 8, 2021

Thanks! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private method support
2 participants