Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(wmr) - fix issue relating to windows module css #872

Merged
merged 2 commits into from
Sep 19, 2021

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Sep 19, 2021

Fixes #871

Format of files in WRITE_CACHE

{
  'index.tsx',
  'pages\\home\\index.js',
  'home.module.css?asset',
  'home.module.css',
  'pages\\_404.js',
  'header.tsx',
  'pages\\home\\style.module.css?asset',
  'pages\\home\\style.module.css'
}

While our cacheKey was in posix format, the cacheKey only seems to affect assets in this matter

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2021

🦋 Changeset detected

Latest commit: e5ad0d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wmr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Size Change: +6 B (0%)

Total Size: 791 kB

Filename Size Change
packages/wmr/wmr.cjs 755 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size
examples/demo/dist/about/index.html 713 B
examples/demo/dist/alias-outside/index.html 693 B
examples/demo/dist/assets/Calendar.********.css 702 B
examples/demo/dist/assets/style.********.css 624 B
examples/demo/dist/chunks/alias-outside.********.js 137 B
examples/demo/dist/chunks/class-fields.********.js 213 B
examples/demo/dist/chunks/compat.********.js 15.3 kB
examples/demo/dist/chunks/hoofd.module.********.js 1.48 kB
examples/demo/dist/chunks/index.********.js 266 B
examples/demo/dist/chunks/json.********.js 239 B
examples/demo/dist/chunks/meta-tags.********.js 299 B
examples/demo/dist/chunks/prerender.********.js 294 B
examples/demo/dist/class-fields/index.html 704 B
examples/demo/dist/compat/index.html 1.54 kB
examples/demo/dist/env/index.html 779 B
examples/demo/dist/error/index.html 708 B
examples/demo/dist/files/index.html 738 B
examples/demo/dist/index.********.js 7.79 kB
examples/demo/dist/index.html 769 B
examples/demo/dist/json/index.html 712 B
examples/demo/dist/lazy-and-late/index.html 714 B
examples/demo/dist/meta-tags/index.html 781 B

compressed-size-action

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@marvinhagemeister marvinhagemeister merged commit ae552e6 into main Sep 19, 2021
@marvinhagemeister marvinhagemeister deleted the module-css-windows branch September 19, 2021 13:23
@github-actions github-actions bot mentioned this pull request Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles from Css modules not being applied in dev mode on windows
2 participants