Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Avoid replacing regex group token when present in html #913

Conversation

cristianbote
Copy link
Member

Fixes #912

Switch from token based replacement to callback based function to avoid replacement of $1 form within html and data contents at prerender time.

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2022

🦋 Changeset detected

Latest commit: 21ec4f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wmr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Size Change: +1 B (0%)

Total Size: 804 kB

Filename Size Change
packages/wmr/wmr.cjs 767 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
examples/demo/dist/about/index.html 721 B
examples/demo/dist/alias-outside/index.html 698 B
examples/demo/dist/assets/Calendar.********.css 694 B
examples/demo/dist/assets/style.********.css 624 B
examples/demo/dist/chunks/alias-outside.********.js 138 B
examples/demo/dist/chunks/class-fields.********.js 211 B
examples/demo/dist/chunks/compat.********.js 15.9 kB
examples/demo/dist/chunks/hoofd.module.********.js 1.48 kB
examples/demo/dist/chunks/index.********.js 200 B
examples/demo/dist/chunks/json.********.js 239 B
examples/demo/dist/chunks/meta-tags.********.js 296 B
examples/demo/dist/chunks/prerender.********.js 294 B
examples/demo/dist/class-fields/index.html 709 B
examples/demo/dist/compat/index.html 1.55 kB
examples/demo/dist/env/index.html 787 B
examples/demo/dist/error/index.html 714 B
examples/demo/dist/files/index.html 743 B
examples/demo/dist/index.********.js 7.83 kB
examples/demo/dist/index.html 775 B
examples/demo/dist/json/index.html 720 B
examples/demo/dist/lazy-and-late/index.html 723 B
examples/demo/dist/meta-tags/index.html 786 B

compressed-size-action

@cristianbote cristianbote merged commit caf7ff8 into main Apr 4, 2022
@cristianbote cristianbote deleted the fix/avoid-replacing-regex-group-token-with-matched-results branch April 4, 2022 13:05
@github-actions github-actions bot mentioned this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerender: regexp capturing group replaces any instance of $1 (etc.)
2 participants