Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove 'pip install' options in recipes #1198

Merged

Conversation

matthewfeickert
Copy link
Contributor

Motivated by conda/grayskull#582 and @wolfv's comment conda/grayskull#582 (comment)

  • Remove --no-deps, --no-build-isolation, and --ignore-installed pip install options in recipes as rattler-build will enforce all required pip install options itself at build time.

c.f.

// python variables
// hard-code this because we never want pip's build isolation
// https://github.com/conda/conda-build/pull/2972#discussion_r198290241
//
// Note that pip env "NO" variables are inverted logic.
// PIP_NO_BUILD_ISOLATION=False means don't use build isolation.
insert!(vars, "PIP_NO_BUILD_ISOLATION", "False");
// Some other env vars to have pip ignore dependencies. We supply them ourselves instead.
insert!(vars, "PIP_NO_DEPENDENCIES", "True");
insert!(vars, "PIP_IGNORE_INSTALLED", "True");

* Remove --no-deps, --no-build-isolation, and --ignore-installed 'pip install'
  options in recipes as rattler-build will enforce all required 'pip install'
  options itself at build time.
@matthewfeickert
Copy link
Contributor Author

This is ready for review. Though as this is my first PR to the repo, I'm going to need someone on the dev team to approve a run of the CI.

@wolfv wolfv merged commit 249d98f into prefix-dev:main Nov 17, 2024
19 checks passed
@wolfv
Copy link
Member

wolfv commented Nov 17, 2024

Thanks @matthewfeickert :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants