Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change default binding of filelines to FL. #1400

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

rzvxa
Copy link
Member

@rzvxa rzvxa commented Jan 8, 2024

Description of Changes

Closes #1399


New Version Info

Changes the Toggle File Lines binding from L to FL to prevent all clashes.
F will prevent backward find in the line but both F and f are already taken as shortcuts in the NERDTree buffer so won't break anything that is already working there.

@rzvxa
Copy link
Member Author

rzvxa commented Jan 8, 2024

@Swivelgames Please give it an approving review if you do agree with this new shortcut so we can speed up the merging process.

@rzvxa rzvxa requested a review from alerque January 8, 2024 23:22
Copy link

@Swivelgames Swivelgames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the speedy turnaround 🚀

@rzvxa rzvxa merged commit 6acfc48 into preservim:master Jan 9, 2024
1 check passed
@rzvxa
Copy link
Member Author

rzvxa commented Jan 9, 2024

@isaiah I just mentioned you here to let you know that the issue discussed in #1384 has been fixed and now you can use the default bindings instead of using the configuration I gave you.

I thought the first report by you was just a fluke but with a second open issue for it on hand I soon realized It may have affected more people than I initially thought so I Just wanted to apologize for this.

Have a great day guys and thank you both for reporting this!

@Swivelgames
Copy link

Works beautifully. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: NERDTree Hijacked Movement Keys
3 participants