Fix broken Pressflow page cache lifetime #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix broken Pressflow page cache lifetime due to use of non-existant config variable, and incorrectly treating it as a timestamp.
Update to Pressflow 6.38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken Pressflow page cache lifetime due to use of non-existent config variable, and incorrectly treating it as a timestamp.
It looks like at some stage someone has tried to fix the default Drupal behaviour of caching pages with CACHE_TEMPORARY. However it has never worked because 1. the wrong variable name is used and 2. even if the correct variable name had been used, the variable stores a TTL but cache_set requires a timestamp.
See
#33 (earlier incomplete pull request)
https://www.drupal.org/node/1279654
https://www.drupal.org/node/2130865