Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.editorconfig is ignored #90

Closed
wojpawlik opened this issue May 4, 2018 · 0 comments · Fixed by #92
Closed

.editorconfig is ignored #90

wojpawlik opened this issue May 4, 2018 · 0 comments · Fixed by #92

Comments

@wojpawlik
Copy link

[email protected]
[email protected]
[email protected]

Extract from my .editorconfig:

[*]
indent_style = space
indent_size = 4

What did you expect to happen?

I expected my code to be indented using 4 spaces.

What actually happened?

My code was indented using 2 spaces, prettier's default.

I worked around this by specifying tabWidth in .prettierrc.json.

The workaround creates duplication. Ignoring .editorconfig is inconsistent with standalone prettier.

Possibly related to #88.
azz added a commit to azz/eslint-plugin-prettier that referenced this issue Jun 4, 2018
@azz
Fix: respect editorconfig
f5ff547 
Fixes prettier#90
@azz azz mentioned this issue Jun 4, 2018
Merged
@azz azz closed this as completed in #92 Jun 12, 2018
azz added a commit that referenced this issue Jun 12, 2018
@azz
Fix: respect editorconfig (#92)
0b04dd3 
Fixes #90

https://prettier.io/docs/en/api.html#prettierresolveconfigfilepath-options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: respect editorconfig azz/eslint-plugin-prettier
1 participant
@wojpawlik