fix(printer-postcss): ignore escape \ and escaped / in Less #5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid messing up Less files containing \/ (escaped /) fix prettier#5208
alexander-akait
requested changes
Dec 5, 2018
alexander-akait
requested changes
Dec 5, 2018
tests/css_scss/scss.scss
Outdated
| @@ -1038,3 +1038,12 @@ $my-map: ( | |||
| .something { | |||
| grid-template-columns: 1 2fr (3 + 4); | |||
| } | |||
|
|
|||
| // Ignore escape "\" in SCSS mixins | |||
| mixin margin-bottom-1\/3 { | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
alexander-akait
requested changes
Dec 5, 2018
| label { | ||
| @include margin-bottom-1\\/3; | ||
| } | ||
|
|
There was a problem hiding this comment.
@mixin margin-bottom-1\/3 {
margin-bottom: 0.8rem;
}
label {
@include margin-bottom-1\/3;
}Add this test, looks you fix issue in scss too, great!
| @@ -2025,7 +2025,7 @@ $my-map: ( | |||
| } | |||
|
|
|||
| // Ignore escape "\\" in SCSS mixins | |||
| mixin margin-bottom-1\\/3 { | |||
| @mixin margin-bottom-1\\/3 { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
i've added
@mixin margin-bottom-1\/3 {
margin-bottom: 0.8rem;
}
label {
@include margin-bottom-1\/3;
}to tests/css_scss/scss.scss and ran yarn test -u. This is auto generated
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid messing up Less files containing \/ (escaped /).
Ignore escape \ and escaped / in Less.
Fix #5208 issue.
docs/directory)✨Try the playground for this PR✨