ProgressBar: add severities support #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let me look. |
|
Actually can you post a screenshot with color: buttoncolor so i can see? So on Saga it llooks like its white
You are saying that is hard to read on the progress bar? |
|
This is how I've done it in the PR: This is how it would look using the buttons text color for the label: |
|
Ahh yes because it crosses over in grey and colored areas i think you have to leave the color text the way you have it. |
|
you should be able to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see primefaces#11404
Not sure what to do with the text color. From my experiments it's better not to use the buttons text color as they may hardly readable if the progressbar values is less than 50%