Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.src folder seems to be exlcuded in node module #23

Closed
RyanPnayR opened this issue Jul 1, 2020 · 7 comments · Fixed by #25
Closed

.src folder seems to be exlcuded in node module #23

RyanPnayR opened this issue Jul 1, 2020 · 7 comments · Fixed by #25
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@RyanPnayR
Copy link

RyanPnayR commented Jul 1, 2020

Error message from build

ERROR in ./node_modules/primeflex/primeflex.scss
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: File to import not found or unreadable: ./src/_variables.
        on line 1 of /node_modules/primeflex/primeflex.scss
>> @import './src/_variables';

Angular json styles

  "styles": [
 "src/style.css",
"shared_assets/sass/base.sass",
"node_modules/primeflex/primeflex.scss",
node_modules/primeng/resources/themes/nova-light/theme.css",              
"node_modules/primeng/resources/primeng.min.css",
"node_modules/quill/dist/quill.core.css"
],
Angular CLI: 9.1.2
Node: 10.19.0
OS: linux x64

Angular: 9.1.2
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.901.2
@angular-devkit/build-angular      0.901.9
@angular-devkit/build-optimizer    0.901.9
@angular-devkit/build-webpack      0.901.9
@angular-devkit/core               9.1.2
@angular-devkit/schematics         9.1.2
@angular/cdk                       9.2.1
@angular/material                  9.2.1
@angular/material-moment-adapter   9.2.1
@ngtools/webpack                   9.1.9
@schematics/angular                9.1.2
@schematics/update                 0.901.2
rxjs                               6.5.5
typescript                         3.7.5
webpack                            4.42.0

I was able to resolve this issue by updating my angular.json to use the css file instead and everything seems to be fine.

            "styles": [
              "src/style.css",
              "../shared_assets/sass/base.sass",
              "node_modules/primeflex/primeflex.css",
              "node_modules/primeng/resources/themes/nova-light/theme.css",
              "node_modules/primeng/resources/primeng.min.css",
              "node_modules/quill/dist/quill.core.css"
            ],
@Jogai
Copy link

Jogai commented Jul 1, 2020

src folder is missing. Should be distributed as well

@yoku2010
Copy link
Contributor

yoku2010 commented Jul 7, 2020

Facing the same issue while creating Angular build. ./src folder is missing in [email protected].

Install npm install [email protected] to fix this.

@juanparati
Copy link

@yoku2010 : Unfortunately the version 1.2.0 has missing the text styles.

@cagataycivici: Is it possible to release a new version? The previous one doesn't have the "src" directory included.

As a temporal solution during the development stage I recommend you to download the last release and overwrite the node_modules/primeflex directory with the release files.

yoku2010 added a commit to yoku2010/primeflex that referenced this issue Jul 9, 2020
cagataycivici added a commit that referenced this issue Aug 26, 2020
fixes #23 - 'src' folder is missing in node modules.
@cagataycivici cagataycivici self-assigned this Aug 26, 2020
@cagataycivici cagataycivici added the enhancement New feature or request label Aug 26, 2020
@cagataycivici cagataycivici added this to the 2.0.0 milestone Aug 26, 2020
@tonyqus
Copy link

tonyqus commented Jul 16, 2021

Hello, I notice that this bug re-appears in 3.0.0 release. Can someone fix it?

@DejanGegic
Copy link

Hello, I notice that this bug re-appears in 3.0.0 release. Can someone fix it?

I have the same issue, been trying to fix it today. I guess older version is the only way to go

@tonyqus
Copy link

tonyqus commented Jul 23, 2021

at least 2.0.0 works for me

@lucabiasotto
Copy link

lucabiasotto commented Sep 4, 2022

Hi, i have the same issue with primeflex 3.1.2.
In this way it seems to work:

import "primeflex/primeflex.css"

it's correct? or there is a better way?
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants