Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect - Object filtering not working with classes #17398

Open
4 tasks
mpiccinnonode opened this issue Jan 15, 2025 · 0 comments · May be fixed by #17399
Open
4 tasks

MultiSelect - Object filtering not working with classes #17398

mpiccinnonode opened this issue Jan 15, 2025 · 0 comments · May be fixed by #17399
Assignees
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@mpiccinnonode
Copy link

mpiccinnonode commented Jan 15, 2025

Describe the bug

If you try and use a multiselect passing an array of class instances to the options property, internal filtering will not work, giving always an empty result set.

Pull Request Link

PR #17399

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

Reproducer

https://stackblitz.com/edit/github-1ildik2r?file=src%2Fapp%2Fapp.component.html

Environment

**OS: ** Windows 11
**IDE: ** JetBrains Webstorm

Angular version

19.0.5

PrimeNG version

v19

Node version

22.9.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Create an array made of class instances
  2. Use a <p-multi-select> and pass the array as [options]
  3. Open MultiSelect's dropdown and try to filter the options
  4. See error (filtered values is always empty)

Image

Image

Expected behavior

Since class instances are objects as well, it is expected by the filter to work as it does with plain objects

@mpiccinnonode mpiccinnonode added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 15, 2025
@mertsincan mertsincan self-assigned this Jan 16, 2025
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 16, 2025
@mertsincan mertsincan added this to the 19.1.0 milestone Jan 16, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Review
Development

Successfully merging a pull request may close this issue.

2 participants