Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #17398 MultiSelect filtering not working with class instances #17399

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mpiccinnonode
Copy link

Defect Fixes

#17398

Notes

The wrong behaviour was caused by the check of the isObject() method from @primeuix/utils giving output false when the value param is a class instance.
However, the method's code seems correct and, reproducing it in the MultiSelect component itself, works as expected.
My best guess is that the MultiSelect is accessing an outdated compiled version of the isObject() method.
Also, it's the only place the said method is used.

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 9:31am
primeng-v18 ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 9:31am

Copy link

vercel bot commented Jan 15, 2025

@mpiccinnonode is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@rosenthalj
Copy link
Contributor

Remove the 2 console.log statements.

Note: I have not reviewed the validity of the code changes.

@mpiccinnonode
Copy link
Author

Remove the 2 console.log statements.

Note: I have not reviewed the validity of the code changes.

Logs removed, many thanks for the comment

@mertsincan mertsincan linked an issue Jan 16, 2025 that may be closed by this pull request
4 tasks
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiSelect - Object filtering not working with classes
3 participants