Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Steplist seperator does not to work with dynamic steps #17482

Closed
4 tasks
DaSchTour opened this issue Jan 24, 2025 · 0 comments · Fixed by #17483
Closed
4 tasks

Steplist seperator does not to work with dynamic steps #17482

DaSchTour opened this issue Jan 24, 2025 · 0 comments · Fixed by #17483
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
19.0.6

Comments

@DaSchTour
Copy link
Contributor

DaSchTour commented Jan 24, 2025 •
edited
Loading

Describe the bug

If the steps are created from a list the step seperator does not show up

Pull Request Link

#17483

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://github.com/DaSchTour/primeng-bugs/tree/main/src/app/stepper

Environment

Independent of the environment

Angular version

19

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

Create a list of steps and step panels dynamically

Expected behavior

The step seperator is correctly displayed
@DaSchTour DaSchTour added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 24, 2025
DaSchTour added a commit to DaSchTour/primeng that referenced this issue Jan 24, 2025
@DaSchTour
fix: make isSeparatorVisible full signal primefaces#17482
0c09c32
@DaSchTour DaSchTour mentioned this issue Jan 24, 2025
Merged
@mertsincan mertsincan linked a pull request Jan 29, 2025 that will close this issue
fix: make isSeparatorVisible full signal #17482 #17483
Merged
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add labels Jan 29, 2025
@mertsincan mertsincan added this to the 19.0.6 milestone Jan 29, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 29, 2025
mertsincan pushed a commit that referenced this issue Jan 29, 2025
@DaSchTour
fix: make isSeparatorVisible full signal #17482 (#17483)
506d819
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
19.0.6
Development

Successfully merging a pull request may close this issue.

fix: make isSeparatorVisible full signal #17482 DaSchTour/primeng
2 participants
@DaSchTour @mertsincan