Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make build scripts cross platform #17498

Closed
4 tasks
davidda opened this issue Jan 25, 2025 · 1 comment
Closed
4 tasks

make build scripts cross platform #17498

davidda opened this issue Jan 25, 2025 · 1 comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@davidda
Copy link
Contributor

davidda commented Jan 25, 2025

Describe the bug

Some of the PrimeNG git repo's (p)npm scripts cannot be executed on Windows due to the way environment variables are used in the scripts.

The solution is to use the "cross-env" tool where required. Tested under Ubuntu and Windows.

Pull Request Link

#17497

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/github/primefaces/primeng-issue-template

Environment

Angular version

19

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

build primeng on windows -> fail

Expected behavior

it builds

@davidda davidda added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 25, 2025
@mertsincan
Copy link
Member

Fixed in #17497

@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 29, 2025
@mertsincan mertsincan added this to the 19.0.6 milestone Jan 29, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 29, 2025
@mertsincan mertsincan moved this from Review to Done in PrimeNG Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
Status: Done
Development

No branches or pull requests

2 participants