Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make build scripts cross platform #17497

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

davidda
Copy link
Contributor

@davidda davidda commented Jan 25, 2025

Some of the PrimeNG git repo's (p)npm scripts cannot be executed on Windows due to the way environment variables are used in the scripts.

The solution is to use the "cross-env" tool where required. Tested under Ubuntu and Windows.

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2025 7:45am
primeng-v18 ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2025 7:45am

Copy link

vercel bot commented Jan 25, 2025

@davidda is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@davidda davidda mentioned this pull request Jan 25, 2025
4 tasks
@mertsincan mertsincan merged commit 152f6f0 into primefaces:master Jan 29, 2025
2 of 6 checks passed
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

@davidda davidda deleted the fix/build-cross-platform branch January 29, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants