fix(#17109): sync p-inputnumber with formcontrol patchvalue #17347
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertsincan
added
the
Resolution: Needs Revision
|
Could you please resolve conflicts in PR? Then, we'll review it. Thanks a lot! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
@ANANTH4004 is attempting to deploy a commit to the primetek Team on Vercel. A member of the Team first needs to authorize it. |
|
Conflicts are resolved Please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #17109, which reports a bug with p-inputNumber not syncing correctly with FormControl when using the patchValue method.
Root Cause
The p-inputNumber component was not updating its internal value when the patchValue method was used on the associated FormControl. This issue caused the UI to remain out of sync with the form control.
Fix
Updated the p-inputNumber component to listen to FormControl value changes and properly update its state whenever patchValue is called.
Testing
Manually tested the fix with a reactive form setup.
Verified that calling patchValue correctly updates the value displayed by p-inputNumber.
Closes #17109.