Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): total records logic #17654

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Bock92
Copy link
Contributor

@Bock92 Bock92 commented Feb 12, 2025

Fix: #17569

Changes in this fix:

  • The totalRecords input property was not considered when calculating the total number of elements, regardless of whether the table was filtered or not.

Implementation Details:

  • The _totalRecords property now correctly represents the original value of @Input() totalRecords.
  • When p-table calculates the total number of records, it will first check if @Input() totalRecords is a valid number.
  • If totalRecords is not valid/set, the table will default to using value.length as the total record count.

Copy link

vercel bot commented Feb 12, 2025

Deployment failed with the following error:

Creating the Deployment Timed Out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: totalRecords has no effect
1 participant