New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datepicker): monthpicker now is getting selected (#17452) #17655

Open

farihaChowdhury wants to merge 1 commit into primefaces:master from farihaChowdhury:fix/#17452-datepicker-month-and-year-selection

farihaChowdhury commented Feb 12, 2025

Problems identified during this fix:

Monthpicker was getting selected only when the 1st day of the month was chosen. The same problem exists in version 19,18 and 17.

Changes made in this fix:

Previuosly monthpicker was not getting selected when date was chosen other than the 1st day of the month. Now month will be selected for any date chosen within the month.

Implementation Details:

The logic of isMonthSelected function in datepicker.ts file had a bug. Previously the logic was able to set to true only for the first day of the month. Now it will not check the date. Rather it will check whether the selected month and year is within the date range.


          fix: monthpicker now is selected (primefaces#17452)

c276548

vercel bot commented Feb 12, 2025

Deployment failed with the following error:

Creating the Deployment Timed Out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet