Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fileupload): add locale and improve formatSize functionality #17662

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(fileupload): add locale and improve formatSize functionality #17662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/primeng/src/fileupload/fileupload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,11 @@ export class FileUpload extends BaseComponent implements AfterViewInit, AfterCon
* @group Props
*/
@Input() invalidFileLimitMessageSummary: string = 'Maximum number of files exceeded, ';
/**
* Locale used to format the maxFileSize within invalidFileSizeMessageDetail accordingly
* @group Props
*/
@Input() locale: string = 'en-US';
/**
* Inline style of the element.
* @group Props
Expand Down Expand Up @@ -1046,15 +1051,17 @@ export class FileUpload extends BaseComponent implements AfterViewInit, AfterCon

formatSize(bytes: number) {
const k = 1024;
const dm = 3;
const sizes = this.getTranslation(TranslationKeys.FILE_SIZE_TYPES);

if (bytes === 0) {
return `0 ${sizes[0]}`;
}

const i = Math.floor(Math.log(bytes) / Math.log(k));
const formattedSize = (bytes / Math.pow(k, i)).toFixed(dm);
const formattedSize = (bytes / Math.pow(k, i)).toLocaleString(this.locale, {
minimumFractionDigits: 0,
maximumFractionDigits: 3
});

return `${formattedSize} ${sizes[i]}`;
}
Expand Down