Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Loading Icon template reference variable #17736

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

taxpayer
Copy link
Contributor

This update normalises the reference variable name of the loading icon template, which currently is "loadingIcon" but should be "loadingicon", following the same standard as other variable names.

Defect Fixes

When submitting a PR, please also create an issue documenting the error and manually link to an issue.

Feature Requests

Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

This update normalises the reference variable name of the loading icon template, which currently is "loadingIcon" but should be "loadingicon", following the same standard as other variable names.
Copy link

vercel bot commented Feb 20, 2025

Deployment failed with the following error:

Creating the Deployment Timed Out.

@mertsincan mertsincan added this to the 19.0.7 milestone Feb 21, 2025
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

@mertsincan mertsincan merged commit 2356621 into primefaces:master Feb 21, 2025
0 of 4 checks passed
@mertsincan mertsincan added the Component: Documentation Issue or pull request is related to Documentation label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants