fix: #6015 IconField compatibility with InputNumber #6523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Thanks for your contribution. To accept this PR, firstly primevue-sass-theme repo should be updated for version 3. |
tugcekucukoglu
added
vue3
Resolution: Needs Revision
|
Thank you for pointing me in the right direction, that makes a lot of sense! I'll open a corresponding change there. |
|
+1, Hopefully we can have this merged soon! |
|
primefaces/primevue-sass-theme#79 Closing this PR temporarily. Will be fixed for the next version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the CSS direct sibling selector, the appropriate padding for the input field could not be applied when InputNumber is used given it's nesting inside a
spanelement.Removing the direct sibling selector and styling more akin to V4 allows the nested input to be detected, however I can gladly update to extend and specifically target the input of the nested number input if preferred.
The
:last-of-typeselector on thep-input-iconelement also fail in this regard due to the nesting, unless the markup is specifically set to have theInputIconappear after theInputText.###Defect Fixes
#6015